Skip to content

Conversation

gordonwatts
Copy link
Collaborator

Summary

  • format dataset sizes in MB, GB, or TB with two decimal places and include a space before the unit
  • test dataset listing for MB, GB, and TB cases

Testing

  • black servicex/app/datasets.py tests/app/test_datasets.py
  • flake8
  • pytest

https://chatgpt.com/codex/tasks/task_e_68927a4af9e8832094127416bee326ca

@gordonwatts gordonwatts self-assigned this Sep 15, 2025
@gordonwatts gordonwatts added the enhancement New feature or request label Sep 15, 2025
@gordonwatts gordonwatts changed the title feat: dynamic dataset size units feat: dynamic dataset size units in cli output Sep 15, 2025
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.24%. Comparing base (63669b9) to head (1fbbc10).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #655      +/-   ##
==========================================
+ Coverage   97.19%   97.24%   +0.05%     
==========================================
  Files          29       29              
  Lines        1958     1998      +40     
==========================================
+ Hits         1903     1943      +40     
  Misses         55       55              
Flag Coverage Δ
unittests 97.24% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codex enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants