Add the DiseasyActivity module #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test(DiseasyActivity): make tests more specific * test(DiseasyActivity): put test value before expected value
* fix(DiseasyActivity): allow scenarios with single activity * fix(DiseasyActivity): always return scenario activities as list
* feat: translate the `dk_activity_units` and `dk_reference_scenario` data sets * feat: add contact_basis data set --------- Co-authored-by: Rasmus Skytte Randløv <[email protected]> Co-authored-by: LasseEngboChr <[email protected]>
feat(DiseasyActivity): improve `$describe()`, `$scenario_matrix`, and `$add_activities()`
--------- Co-authored-by: Lasse Engbo Christiansen <[email protected]>
…/diseasy into diseasy_activity_weighing
feat(DiseasyActivity): improve function signatures for weighing
* fix(dk_activity_units): cross check numerical values * fix(DiseasyActivity): make normalisation robust * docs(contact_basis): use country name in description * docs: use long names for demography * docs(DiseasyActivity): minor fixes to docs * test(DiseasyActivity): fix broken tests
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 83.60% 83.98% +0.37%
==========================================
Files 7 8 +1
Lines 543 843 +300
==========================================
+ Hits 454 708 +254
- Misses 89 135 +46 ☔ View full report in Codecov by Sentry. |
|
This PR is a formality to ensure CI tests are working and to provide an account of the changes. |
RasmusSkytte
added a commit
that referenced
this pull request
Dec 16, 2024
Add the DiseasyActivity module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
This PR replaces #30 which became too large to review conveniently.
This PR is as large, but consists of a number of smaller PRs that have been individually reviewed.
$describe(),$scenario_matrix, and$add_activities()#61This PR fixes #21 and fixes #31
Approach
The approaches are varied and specified in each PR
Known issues
N/A
Checklist
NEWS.md