-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linters and fix linting issues #78
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
==========================================
+ Coverage 83.98% 86.77% +2.79%
==========================================
Files 8 8
Lines 843 885 +42
==========================================
+ Hits 708 768 +60
+ Misses 135 117 -18 ☔ View full report in Codecov by Sentry. |
0aac314
to
0b95760
Compare
kaare-gr
approved these changes
Jan 4, 2024
kaare-gr
approved these changes
Jan 4, 2024
RasmusSkytte
added a commit
that referenced
this pull request
Dec 16, 2024
Add linters and fix linting issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
This PR adds the linters developed for
diseasystore
and creates a new linter that checks for correct formatting of @param and @field roxygen tags.Approach
The functions from
diseasystore
were copied over.The linter for @param and @field tags looks for lines with these, and ensures they contain back ticks ` and carriage returns.
This is the proxy used to check it adheres to the MLR3 documentation templates.
Finally, the lints the new linters finds are resolved
Known issues
Lintr fails for
quick-start.Rmd
. This is due to the vignette not being written yet and is outside the scope of this PR.Document workflow fails currently, but this is being fixed elsewhere (AEF-DDF/)Documentation is updated -- the workflow fails for other reasons.Checklist
NEWS.md