-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
combineasy
and the DiseasyEnsemnle
class
#166
Draft
RasmusSkytte
wants to merge
175
commits into
main
Choose a base branch
from
feature/combineasy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
This PR adds helpers to creating and managing model ensembles
Approach
This Pr Adds the
combineasy()
helper function which injects parameters and functional modules into model templates to create the model ensemble.A model ensemble is here a list of model instances which we give the class
DiseasyEnsemble
.By giving the class to list, we can now create the standard generics
print
,summary
andplot
which allows us to inspect the ensemble and create plots from it.Known issues
A
predict
generic should probably be added and used internally inplot
.Missing
fig.alt
text increating-ensembles.Rmd
Gracefully handle missing suggests in
creating-ensembles.Rmd
plot()
example is missing argumentsWaiting on
DiseasyModelRegression
#164Checklist
NEWS.md