-
Notifications
You must be signed in to change notification settings - Fork 0
Fully featured DiseasyModelOde
#162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
74c444f
to
35e20e8
Compare
ad5599f
to
db24936
Compare
6 tasks
90c9ce9
to
9b504a4
Compare
9b504a4
to
32897e2
Compare
32897e2
to
29f5422
Compare
kaare-gr
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vignettes may be reviewed further separately.
Vignettes updated after discussion with Kaare -- merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Fixes #154, #141
This PR improves the implementation of
DiseasyModelOde
andDiseasyModelOdeSeir
Approach
$get_results()
function can now be called forDiseasyModelOde
.$plot()
method has been added to easily visualise the model results (works with theplot()
generic)DiseasyModelOde
initialise_state_vector
we now actually use "incidence" for the input data (previously we used a different normalisation by accident and providing the incidence gave wrong results (The "SEIR-initialisation" vignette has been updated accordingly)DiseasyModelOdeSeir
.In addition, a number of fixes has been made and features added
DiseasyObservables$get_observation
called "respect_last_queryable_date" to allow the fetching of databeyond the
last_queryable_date
.DiseasyObservables
are now closed as expected.hash_environment
has been improved to allow arbitrarily nested functions.Known issues
Waiting on the following
Release diseasystore 0.3.1 diseasystore#206Tests fail on
r-devel
. I can't wait to see how R manages to make dates "equal" but not "identical".Checklist
NEWS.md