-
-
Notifications
You must be signed in to change notification settings - Fork 961
Fixes spelling errors #1668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes spelling errors #1668
Conversation
…s in test projects
@@ -1,4 +1,7 @@ | |||
[*.cs] | |||
spelling_languages = en-us,en-gb | |||
spelling_exclusion_path = ../exclusion.dic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the file this is pointing to has only 2 words, both already included in the top-level file. Is it an artifact of earlier changes?
spelling_exclusion_path = ../exclusion.dic | |
spelling_exclusion_path = ../../exclusion.dic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the (redundant?) file I am talking about
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another behavior (bug) in Visual Studio spellchecker. There were some times when it would honor the exclusion.dic
file in the root and other times when it would only honor the one in the immediate same folder as the project/.editorconfig
. From your fix, its possible I had my path wrong. Either way, I got tired of troubleshooting MS/VS issues and in the end tried to focus on the point of the PR which was to fix a few spelling errors, not necessarily build a spellchecking tool pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, thanks
See #1269 for some relevant discussion
List of changes
exclusion.dic
file for spellchecker words to ignore.editorconfig(s)
to configure VS spellchecker for the library and unit test projectsTesting
All existing unit tests continue to pass.
Impact Analysis
None. No functional changes or public-facing APIs have been changed.