chore: allow longer lines in commit messages #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louib
force-pushed
the
configure-commitlint
branch
13 times, most recently
from
8423ab3 to
23bc131
Compare
|
I recommend getting rid of the limit altogether or make it something like 4096 |
louib
force-pushed
the
configure-commitlint
branch
from
23bc131 to
faab197
Compare
droidmonkey
approved these changes
Sep 8, 2024
sseemayer
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 100 character limit in the commit body is very limiting, especially when we want to include URLs. This PR should make the situation slightly better, although I think in the future we should completely disable the line length check if a line is found to contain a URL. This would also allow us to preserve a smaller length limit for lines that do not container a URL.