-
Notifications
You must be signed in to change notification settings - Fork 24
Autodetect "packages" based on cabal.project
(and package.yaml
)
#110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation works (no globs supported); what's left - refactoring, better error messages, and documentation update. |
cabal.project
(and package.yaml
)cabal.project
(and package.yaml
)
This is great, makes it easier to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #76 & adds a
projectRoot
option.This PR doesn't implement support for globs; users are expected to write down each package by hand in
cabal.project
. Latter we can improve this.cabal.project
can live in a sub directory (eg:./Backend
). Do we support this case, and if so how? (EDIT: Can just addprojectRoot
option)and maybe consider putting this code in external flake?throw
ing parse errors*
), print the limitation asking the user to set "packages" manually.With this PR, haskell-flake gets its first flake dependency https://github.com/kanwren/nix-parsec which is slightly concerning, because the goal is to keep haskell-flake a thin abstraction on top of nixpkgs without growing to be a behemoth (eg: haskell.nix).(EDIT: Decided to just usefetchGit
for this dependency, which is only evaluated if the user evaluates the default)