Port to the latest Javascript driver version

[vmarkovtsev]

We need to investigate why the newer releases do not work with our code, report possible bugs to Babelfish and switch to the latest JS driver version.

[vmarkovtsev]

BTW @zurk this can be fused with the annotations refactoring.

[zurk]

I'd like to do it separately.

[vmarkovtsev]

"The latest JS driver" does not mean UASTv2 - it means upgrading the driver. And regarding the annotations, I am afraid that you will have to repeat some of the work twice otherwise.

[vmarkovtsev]

If we see that the latest JS driver works incorrectly with UASTv1 protocol, we should report it as an issue and ask LA to fix it ASAP.

[zurk]

If we see that the latest JS driver works incorrectly with UASTv1 protocol, we should report it as an issue and ask LA to fix it ASAP.

Ok, I know that there are some issues for sure. AFAIK, UASTv1 is not clearly the same as an annotated mode in new drivers. Will see.

And regarding the annotations, I am afraid that you will have to repeat some of the work twice otherwise.

It is fine. Annotation is about the shape of the code and this issue can touch its logic.

[zurk]

I report several minor issues related to javascript driver:

• Operator Role missing position information bblfsh/javascript-driver#65
• Missing token for StringLiteralTypeAnnotation bblfsh/javascript-driver#66

However, the biggest problem is on our side. We currently use v1.2.0 driver and the driver wrongly returns Node positions for Unicode string. v2.6.0 returns offsets for byte string, so we should recalculate them back to Unicode.

[zurk]

One more. bblfsh/javascript-driver#67
I think that there are more files that are parsable with v1.2.0 but not with v2.6.0
I am going to create a list tomorrow.

[zurk]

PR: #692
Issue is blocked until v.2.7.0 driver release.