Add bytes to unicode converters #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zurk
force-pushed
the
bytes_to_str
branch
2 times, most recently
from
b212f27 to
b48822c
Compare
vmarkovtsev
requested changes
Mar 19, 2019
|
https://github.com/src-d/lookout-sdk-ml/pull/70/files#r266958347 check all unresolved conversation to see all minor issues left |
zurk
force-pushed
the
bytes_to_str
branch
3 times, most recently
from
b995294 to
1e7108f
Compare
vmarkovtsev
requested changes
Mar 20, 2019
lookout/core/data_requests.py
Outdated
| changes = request_changes( | ||
| data_service.get_data(), ptr_from, ptr_to, contents=False, uast=True) | ||
| return func(self, ptr_from, ptr_to, data_service, changes=changes, **data) | ||
| def wrapped_with_changed_uasts_(func): |
There was a problem hiding this comment.
Suggested change
| def wrapped_with_changed_uasts_(func): | |
| def configured_with_changed_uasts(func): |
lookout/core/data_requests.py
Outdated
| """ | ||
| Decorator to provide "changes" keyword argument to `**data` in `Analyzer.analyze()`. | ||
|
|
||
| "changes" contain the list of `Change` - see lookout/core/server/sdk/service_data.proto. | ||
| The changes will have only UASTs, no raw file contents. | ||
| Decorated method should have the signature compatible with `Analyzer.analyze()`. |
There was a problem hiding this comment.
Suggested change
| Decorated method should have the signature compatible with `Analyzer.analyze()`. | |
| Decorated method should have a signature compatible with `Analyzer.analyze()`. |
lookout/core/data_requests.py
Outdated
|
|
||
| :param func: Method with the signature compatible with `Analyzer.analyze()`. | ||
| :param unicode: Set to True if content and UAST should be converted to unicode format. \ |
There was a problem hiding this comment.
Suggested change
| :param unicode: Set to True if content and UAST should be converted to unicode format. \ | |
| :param unicode: Value indicating whether `content` and UAST positions should be converted to Unicode. \ |
Signed-off-by: Konstantin Slavnov <[email protected]>
vmarkovtsev
approved these changes
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to src-d/style-analyzer#666
To use v2 drivers for javascript it is required to add
UnicodeDataServiceandBytesToUnicodeConverterclasses.