Integration test fixes #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows without this build tag the options can be passed as `/c`. This will be disabled. See: https://godoc.org/github.com/jessevdk/go-flags#hdr-Supported_features Signed-off-by: Lou Marvin Caraig <[email protected]>
Tests ran the bat file for Windows uses the default timeout of 10m. This has to be aligned with the Makefile that uses 20m. Signed-off-by: Lou Marvin Caraig <[email protected]>
Logs were not properly escaped so this was needed. This is not needed anynmore since we're using go-cli. Signed-off-by: Lou Marvin Caraig <[email protected]>
The link is not necessary, maybe it was for some previous version. As a side-effect that link was adding an additional name to the `srcd-cli-bblfshd` container that sometimes prevents it from being pruned correctly. The problem occurred because during the pruning we use the first name in the list of names of a container. Once `srcd-cli-bblfshd-web` is started, the first name of the bblfsh server becomes `srcd-cli-bblfsh-web/srcd-cli-bblfshd` (due to the link explained above). This "extra" name is removed once the container `srcd-cli-bblfshd-web` is removed. So when listing the containers to prune, if `srcd-cli-bblfshd-web` is removed before `srcd-cli-bblfsh-web/srcd-cli-bblfshd`, when we try to remove `srcd-cli-bblfsh-web/srcd-cli-bblfshd` that container doesn't actually exist anymore, at least it doesn't exist with that name. Signed-off-by: Lou Marvin Caraig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially address #456.
I wrote a proper description for each commit.