srcd parse: do not check the list of languages #449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
se7entyse7en
approved these changes
Apr 19, 2019
smacker
reviewed
Apr 22, 2019
| @@ -123,6 +110,12 @@ func (cmd *parseUASTCmd) Execute(args []string) error { | |||
| } | |||
|
|
|||
| if err != nil { | |||
| if strings.Contains(err.Error(), "missing driver for language") { | |||
There was a problem hiding this comment.
do we have an issue in bblfsh to export this error instead of strings.Contains?
There was a problem hiding this comment.
yes, it's this one https://github.com/src-d/engine/issues/297
There was a problem hiding this comment.
wait. this is an issue in engine about aliasing.
I'm talking about an issue in bblfsh-sdk / bblfsh-go-client that would differentiate lang not found error from any other error.
I don't see any link or any conversation about it in 297.
smacker
approved these changes
Apr 22, 2019
Signed-off-by: Carlos Martín <[email protected]>
Signed-off-by: Carlos Martín <[email protected]>
carlosms
force-pushed
the
297-workaround
branch
from
c96dfcf to
1f158ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for #297.
The command now does not try to check if the file language is in the list of bblfsh drivers. But if bblfsh reports that the parsing failed because of a missing driver, engine will still print the same nice error message with the current list of supported languages.
It works for
c#-> bblfshcsharpc++-> bblfshcpp.It still fails for
shell-> bblfshbash.Unfortunately now that the tests parse the cpp and csharp files, they fail, so I had to disable them.
See bblfsh/cpp-driver#31, bblfsh/bblfshd#259