Use gtk3 instead of 2 #21
Conversation
dlgs_linux.go
Outdated
| ** returning from the dialog functions. | ||
| ** Not sure how this interacts with an actual GTK app... */ | ||
| for gtk.EventsPending() { | ||
| gtk.MainIteration() |
There was a problem hiding this comment.
Hm, can you elaborate on why this is no longer needed? Is it something to do with the switch to glib.IdleAdd? If that is doing what I think it is doing (submitting a function to be run as part of the main loop), does that break functionality for non-gtk apps?
I tried to test myself but I'm getting build errors upstream and don't have time to investigate tonight, eg.:
# github.com/gotk3/gotk3/glib
../../gotk3/gotk3/glib/glib.go:260: cannot use idleSrc (type *_Ctype_GSource) as type *_Ctype_struct__GSource in function argument
../../gotk3/gotk3/glib/glib.go:283: cannot use timeoutSrc (type *_Ctype_GSource) as type *_Ctype_struct__GSource in function argument
../../gotk3/gotk3/glib/glib.go:294: cannot use src (type *_Ctype_struct__GSource) as type *_Ctype_GSource in function argument
There was a problem hiding this comment.
I think they are related, yes. I remember we were having problems as we have other gtk parts in our app, and switched to send the dialogs into the main loop.
I see this approach doesn't work properly in programs that doesn't have a gtk main loop already running. I need to investigate more how to support both our needs and the non-gtk app needs.
|
Let's remove the sending of dialogs into the main loop, and go step by step. I think now is just the migration to gtk3. And I'll explore the other improvements more before pushing them into a pull-req. Sorry for the noise. |
|
No apology necessary, thanks for doing the work! I've filed #25 to follow up on the gtk interaction. |
Closes #4