Genericized (was test.check specific) compiler changes for downstream macro/ns resolution

[willcohen]

Reopening as followup to #803, which autoclosed when #802 merged. Needed for squint-cljs/cherry#184, which I similarly need to rebase and re-open based on this.

Please answer the following questions and leave the below in as part of your PR.

• This PR corresponds to an issue with a clear problem statement.

• This PR contains a test to prevent against future regressions

• I have updated the CHANGELOG.md file with a description of the addressed issue.

[willcohen]

Eep. Stuff still changing underneath. This can happen later.

[borkdude]

Hehe sorry. I wasn't done with cljs.test but it's published now and no changes planned.

[willcohen]

@borkdude this is now ready — took a little finagling after cljs.test settled. One more small proposed change to macros. I needed this for test.check because defspec bodies carry (prop/for-all …) aliased (not :refer'd), so without this the macro never fired: the compiled JS emitted a raw prop.for_all(…) runtime call, which was causing undefined errors.

diff --git a/src/squint/compiler_common.cljc b/src/squint/compiler_common.cljc
index a57e5959..3afcd824 100644
--- a/src/squint/compiler_common.cljc
+++ b/src/squint/compiler_common.cljc
@@ -809,6 +809,9 @@
                      as
                      (update-in [current :aliases] (fn [aliases]
                                                      ((fnil assoc {}) aliases as libname)))
+                     (and as (symbol? original-libname))
+                     (update-in [current :macro-aliases]
+                                (fn [aliases] (merge {as original-libname} aliases)))
                      (symbol? original-libname)
                      (update-in [current :aliases] (fn [aliases]
                                                      ((fnil assoc {}) aliases

[willcohen]

Rebased to sit on top of latest changes to squint. squint-cljs/cherry#186 updated as well.

[borkdude]

I'm not yet sure about this approach. clojure.test is a built-in namespace but clojure.test.check is an external dependency in ClojureScript so I don't think this change belongs in squint.

[willcohen]

Makes sense. I'll give it a shot.

[willcohen]

Here's a lighter touch approach to squint. I dropped the test.check specific stuff here, and cherry now handles that via env.

Three new commits:

First: "Populate :macro-aliases from :require :as so plain require finds built-in macros". Same content as before, rebased onto current main.
Second (new): "Make :cherry target of resolve-ns honor :resolve-ns env hook for symmetry with :squint". Cherry was already passing :resolve-ns from cli.cljs, just unused on the :cherry path.
Third (also new): "Filter :refer'd macros via env-supplied :built-in-macro-nss". Adds an inline env hook in the :refer filter so downstream targets register their own macro names without squint knowing about them.

[willcohen]

To better decouple this from the various cherry PRs that depend on it, I've added red/green tests preceding each of the three commits, which should allow this to be self-contained. @borkdude

[willcohen]

Merged main in so this now applies cleanly after #816.

[willcohen]

I’m happy to have this and the associated cherry issues and PRs closed if just feels like churn. Squint’s got enough implemented now that my use case for cherry has largely dropped away. Test.check could be cool but there’s probably a way to rebuild it using something else quick check like in JS.

I still think such downstream flexibility COULD be useful but it could deserve more baking at a later date.