chore: Bump Perception to 2.0 #376
Conversation
robmaceachern
changed the title
| @@ -59,7 +59,7 @@ let package = Package( | |||
| .package(url: "https://github.com/pointfreeco/swift-case-paths", from: "1.5.5"), | |||
| .package(url: "https://github.com/pointfreeco/swift-identified-collections", from: "1.0.0"), | |||
| .package(url: "https://github.com/pointfreeco/swift-macro-testing", from: "0.4.0"), | |||
| .package(url: "https://github.com/pointfreeco/swift-perception", from: "1.5.0"), | |||
| .package(url: "https://github.com/pointfreeco/swift-perception", from: "2.0.0"), | |||
There was a problem hiding this comment.
(commenting here for threading support) – just an FYI, but i believe the 'memory leak fix' was reverted from the 6.2 release branch (see here). idk exactly how that corresponds to what's in any given Xcode beta. sadly no justification was given in any of the PRs so not sure what the underlying motivation was.
There was a problem hiding this comment.
Oh interesting. It looks like the pointfree folks haven't removed it from their backport at this point...
Pinged them about it here: pointfreeco/swift-perception#153
There was a problem hiding this comment.
We'll look into getting those changes into Perception soon. I pinged their PR for more context, so hopefully they can provide some.
| if tracker.isComplete == false { | ||
| XCTFail("state.child should not change.") | ||
| } |
There was a problem hiding this comment.
This is the same kind of approach used in Perception now: https://github.com/pointfreeco/swift-perception/blob/main/Tests/PerceptionTests/PerceptionTrackingTests.swift#L32
The issue is that the registrar deinit pathway will now trigger an onChange which we don't really want to "count" in this context.
Related to pointfreeco/swift-perception#153
tuist install --update --path Samplesto update Sample resolved dependenciesThis bumps the pointfreeco/swift-perception dependency to 2.0 which includes a memory leak fix and improved perception check performance (that our developers have complained about in the past).
Checklist