Skip to content

[WIP] Add support for observing AnyWorkflowConvertible to WorkflowHost #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions Workflow/Sources/WorkflowHost.swift
Original file line number Diff line number Diff line change
Expand Up @@ -100,3 +100,40 @@ public final class WorkflowHost<WorkflowType: Workflow> {
return outputEvent
}
}

extension WorkflowHost {
/// Initializes a new host with the given workflow at the root.
///
/// - Parameter workflow: The root workflow in the hierarchy
/// - Parameter debugger: An optional debugger. If provided, the host will notify the debugger of updates
///
@_disfavoredOverload
public convenience init<AnyWorkflowType: AnyWorkflowConvertible>(
workflow: AnyWorkflowType,
debugger: WorkflowDebugger? = nil
) where WorkflowType == AnyWorkflowWrapper<AnyWorkflowType.Rendering, AnyWorkflowType.Output> {
self.init(workflow: AnyWorkflowWrapper(workflow), debugger: debugger)
}
}

public typealias AnyWorkflowHost<Rendering, Output> = WorkflowHost<AnyWorkflowWrapper<Rendering, Output>>

/// A wrapper around an AnyWorkflow that allows consumers to create a WorkflowHost from an
/// `AnyWorkflowConvertible`.
public struct AnyWorkflowWrapper<Rendering, Output>: Workflow {
public typealias State = Void
public typealias Output = Output
public typealias Rendering = Rendering

var wrapped: AnyWorkflow<Rendering, Output>

public init<W: AnyWorkflowConvertible>(_ wrapped: W) where W.Rendering == Rendering, W.Output == Output {
self.wrapped = wrapped.asAnyWorkflow()
}

public func render(state: State, context: RenderContext<Self>) -> Rendering {
return wrapped
.mapOutput { AnyWorkflowAction(sendingOutput: $0) }
.rendered(in: context)
}
}
25 changes: 2 additions & 23 deletions WorkflowUI/Sources/Hosting/WorkflowHostingController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@

private(set) var rootViewController: UIViewController

private let workflowHost: WorkflowHost<RootWorkflow<ScreenType, Output>>
private let workflowHost: AnyWorkflowHost<ScreenType, Output>

private let (lifetime, token) = Lifetime.make()

Expand All @@ -40,7 +40,7 @@
}

public init<W: AnyWorkflowConvertible>(workflow: W, rootViewEnvironment: ViewEnvironment = .empty) where W.Rendering == ScreenType, W.Output == Output {
self.workflowHost = WorkflowHost(workflow: RootWorkflow(workflow))
self.workflowHost = WorkflowHost(workflow: workflow)

self.rootViewController = workflowHost
.rendering
Expand Down Expand Up @@ -144,27 +144,6 @@
}
}

/// Wrapper around an AnyWorkflow that allows us to have a concrete
/// WorkflowHost without WorkflowHostingController itself being generic
/// around a Workflow.
fileprivate struct RootWorkflow<Rendering, Output>: Workflow {
typealias State = Void
typealias Output = Output
typealias Rendering = Rendering

var wrapped: AnyWorkflow<Rendering, Output>

init<W: AnyWorkflowConvertible>(_ wrapped: W) where W.Rendering == Rendering, W.Output == Output {
self.wrapped = wrapped.asAnyWorkflow()
}

func render(state: State, context: RenderContext<RootWorkflow>) -> Rendering {
return wrapped
.mapOutput { AnyWorkflowAction(sendingOutput: $0) }
.rendered(in: context)
}
}

@available(*, deprecated, renamed: "WorkflowHostingController")
public typealias ContainerViewController = WorkflowHostingController

Expand Down