Unregister metrics when stopping monitoring them

square · Dec 6, 2019 · 6cce7f4 · 6cce7f4
1 parent 2320a90
commit 6cce7f4
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/pkg/ds/farm.go b/pkg/ds/farm.go
@@ -580,6 +580,18 @@ func (dsf *Farm) spawnDaemonSet(
 			for {
 				select {
 				case <-ctx.Done():
+					for _, name := range ds.MetricNames("healthy") {
+						p2metrics.Registry.Unregister(name)
+					}
+					for _, name := range ds.MetricNames("critical") {
+						p2metrics.Registry.Unregister(name)
+					}
+					for _, name := range ds.MetricNames("unknown") {
+						p2metrics.Registry.Unregister(name)
+					}
+					for _, name := range ds.MetricNames("warning") {
+						p2metrics.Registry.Unregister(name)
+					}
 					return
 				case <-ticks.C:
 					eligible, err := ds.EligibleNodes()