Add support for zip archive type for Windows and macOS #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary releases at https://github.com/sqldef/sqldef use tar.gz for linux while zip for windows and darwin.
Github returns an additional 302 to follow the repository move which had made the downloading code broken.
This change is optional as long as the repository is kept at sqldef/sqldef and GitHub doesn't change how it redirects but works as a nice safeguard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I installed https://github.com/sqldef/sqldef-rails and ran
bundle exec rake db:schema:dumptoday. It caused errors due to following 3 reasons:Etc.uname == 'arm64'is not expected. Error message:This PR fixes the errors and makes the sqldef-rails working on macOS.
Environment:
uname -m: