fix parseDriver function to return a correct Driver when using MySQL#2692
Closed
p1ass wants to merge 1 commit intosqlc-dev:mainfrom
Closed
fix parseDriver function to return a correct Driver when using MySQL#2692p1ass wants to merge 1 commit intosqlc-dev:mainfrom
parseDriver function to return a correct Driver when using MySQL#2692p1ass wants to merge 1 commit intosqlc-dev:mainfrom
Conversation
Contributor
|
@kyleconroy Why did you CLOSE this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
#2690
Description
The former
parseDriver function only returns PostgreSQL drivers, so it never returns go-sql-driver.This behavior makes it necessary to specify an option
sql_driverwhenever we use:copyfrom.This PR changes the parseDriver function's behavior to return a correct driver according to the specified DB engine.
As a result of this change, we will not need to add the option.