Add opentelementry extensions #98
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gechetspr
requested changes
Aug 15, 2024
alpine/3.18/8.2/Dockerfile
Outdated
|
|
||
| ARG PHP_PECL_EXTENSIONS="\ | ||
| apcu \ | ||
| opentelemetry \ |
There was a problem hiding this comment.
please move those to ADDITIONAL_PHP_PECL_EXTENSIONS section
Also we need to build images and test them locally.
Afterwards we need to get an approve from @alexanderM91 and after merge build will be triggered for docker hub.
Also please do the same for 8.1 version
Contributor
Author
There was a problem hiding this comment.
updated Dockerfile for all PHP version
Collaborator
|
Closed in favor of #111 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
These changes add open telemetry extensions that allow open telemetry-based amp monitoring
Checklist