-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some improvements for next major release #21
base: next
Are you sure you want to change the base?
Conversation
- Added Return Types - Remove unnecessary consts - use regex group name for more readability - cast variables to string - fixed compatibility for PHP < 8.0 with substr
Codecov Report
@@ Coverage Diff @@
## next #21 +/- ##
============================================
+ Coverage 94.11% 94.78% +0.66%
- Complexity 103 104 +1
============================================
Files 1 1
Lines 221 230 +9
============================================
+ Hits 208 218 +10
+ Misses 13 12 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
- revert signature change for resultScale - revert deletion of deprecated function
Thanks a lot for your contribution Lets separate those into two different things:
The next branch will then eventually become a new major version in the future. I added this to the docs: https://github.com/spryker/decimal-object/blob/master/docs/README.md#contributing |
@dereuromark So I have changed the target to next. I think this changes would be great :-) |
This reverts commit e8fcc32.
Cool |
I have updated the code. So the next release will support only PHP Versions > 8.0 |
I have seen your Repo and find it very useful. So I want to contribute some useful changes.
Changes:
PR Description
Done some code styles fixes and a bugfix with PHP < 8.0 in strict type mode
Checklist