Skip to content

Support externalDocs configure on SpecPropertiesCustomizer #3042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import java.util.function.Supplier;

import io.swagger.v3.oas.models.Components;
import io.swagger.v3.oas.models.ExternalDocumentation;
import io.swagger.v3.oas.models.OpenAPI;
import io.swagger.v3.oas.models.Operation;
import io.swagger.v3.oas.models.PathItem;
Expand Down Expand Up @@ -90,6 +91,7 @@
*
* @author Anton Tkachenko [email protected]
* @author bnasslahsen
* @author Hujin Hong
*/
public class SpecPropertiesCustomizer implements GlobalOpenApiCustomizer {

Expand Down Expand Up @@ -148,6 +150,27 @@ private void customizeOpenApi(OpenAPI openApi, OpenAPI openApiProperties) {
if (!CollectionUtils.isEmpty(openApiProperties.getServers())) {
openApi.setServers(new ArrayList<>(openApiProperties.getServers()));
}

ExternalDocumentation externalDocumentationProperties = openApiProperties.getExternalDocs();
if (externalDocumentationProperties != null) {
customizeExternalDocs(openApi, externalDocumentationProperties);
}
}
}

/**
* Customized external docs.
*
* @param openApi the open api
* @param externalDocumentationProperties the external documentation
*/
private void customizeExternalDocs(OpenAPI openApi, ExternalDocumentation externalDocumentationProperties) {
ExternalDocumentation externalDocumentation = openApi.getExternalDocs();
if (externalDocumentation != null) {
resolveString(externalDocumentation::description, externalDocumentationProperties::getDescription);
resolveString(externalDocumentation::url, externalDocumentationProperties::getUrl);
} else {
openApi.setExternalDocs(externalDocumentationProperties);
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ springdoc:
- hello
summary: Summary of Get operationId 'persons'
description: Description of Get operationId 'persons'

external-docs:
description: External docs description
url: "https://example.com/external-docs"

group-configs:
- group: apiGroupName
open-api:
Expand All @@ -52,10 +55,13 @@ springdoc:
name:
description: Description for 'name' property in ApiGroupName
example: Example value for 'name' property in ApiGroupName

paths:
/persons2:
get:
summary: Summary of operationId 'persons' in ApiGroupName
description: Description of operationId 'persons' in ApiGroupName
external-docs:
description: External docs description for ApiGroupName
url: "https://example.com/apiGroupName-external-docs"

Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ springdoc:
type: http
scheme: bearer
bearer-format: JWT
external-docs:
description: Example External Docs demo
url: "https://example.com/external-docs-demo"
- group: user
display-name: User Interfaces
packages-to-scan:
Expand All @@ -46,6 +49,9 @@ springdoc:
name:
description: Description for 'name' property
example: Example value for 'name' property
external-docs:
description: Example External Docs user
url: "https://example.com/external-docs-user"
open-api:
servers:
- url: "https://api.example.com"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -127,5 +127,9 @@
"bearerFormat": "JWT"
}
}
},
"externalDocs": {
"description": "External docs description for ApiGroupName",
"url": "https://example.com/apiGroupName-external-docs"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -125,5 +125,9 @@
"bearerFormat": "JWT"
}
}
},
"externalDocs": {
"description": "External docs description",
"url": "https://example.com/external-docs"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -58,5 +58,9 @@
"bearerFormat": "JWT"
}
}
},
"externalDocs": {
"description": "Example External Docs demo",
"url": "https://example.com/external-docs-demo"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -51,5 +51,9 @@
"description": "Description for PersonDTO component"
}
}
},
"externalDocs": {
"description": "Example External Docs user",
"url": "https://example.com/external-docs-user"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -127,5 +127,9 @@
"bearerFormat": "JWT"
}
}
},
"externalDocs": {
"description": "External docs description for ApiGroupName",
"url": "https://example.com/apiGroupName-external-docs"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -125,5 +125,9 @@
"bearerFormat": "JWT"
}
}
},
"externalDocs": {
"description": "External docs description",
"url": "https://example.com/external-docs"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -58,5 +58,9 @@
"bearerFormat": "JWT"
}
}
},
"externalDocs": {
"description": "Example External Docs demo",
"url": "https://example.com/external-docs-demo"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -51,5 +51,9 @@
}
}
}
},
"externalDocs": {
"description": "Example External Docs user",
"url": "https://example.com/external-docs-user"
}
}