Skip to content

Move Spring Messaging and Reactor dependencies from core to jline #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
piotrooo wants to merge 1 commit into from
Closed

Move Spring Messaging and Reactor dependencies from core to jline #1230

piotrooo wants to merge 1 commit into from

Conversation

@piotrooo
Copy link
Contributor

@piotrooo piotrooo commented Dec 23, 2025 •
edited
Loading

As this dependency is used only in the jline module, it should reside there.

This is the very first step to mitigate the usage of Spring Messaging and Reactor (#1213 and #1205).

Additionally, an .editorconfig file was added to help with indentation for users who use spaces instead of tabs.

@fmbenhassine
Copy link
Contributor

fmbenhassine commented Dec 23, 2025

This is great! I like how the core module is streamlined with less dependencies. I did something similar for ST4 as well: 70a37c4

Reabsed and merged as 1b30182. Thank you for the PR 🙏

@fmbenhassine fmbenhassine added this to the 4.0.0 milestone Dec 23, 2025
@fmbenhassine fmbenhassine added the type/enhancement Is an enhancement request label Dec 23, 2025
@piotrooo piotrooo deleted the housekeeping/cleanup-messaging-dependencies branch December 23, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type/enhancement Is an enhancement request

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@piotrooo @fmbenhassine