Remove RelyingPartyRegistration deprecations #17329
Open
+204
−488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
requested changes
Jun 24, 2025
There was a problem hiding this comment.
Thanks, @ngocnhan-tran1996, this is a big help. I've left my feedback inline.
| @@ -48,7 +48,8 @@ public final class OpenSamlRelyingPartyRegistration extends RelyingPartyRegistra | |||
| super(registration.getRegistrationId(), registration.getEntityId(), | |||
There was a problem hiding this comment.
Will you please remove this class in this PR as well? Please place it in a separate commit so that it can easily be restored in the event that a concern arises.
| logoutResponse.setIssuer(issuer); | ||
| logoutResponse.setDestination(registration.getSingleLogoutServiceResponseLocation()); | ||
| return logoutResponse; | ||
| } | ||
|
|
||
| public static LogoutRequest relyingPartyLogoutRequest(RelyingPartyRegistration registration) { |
There was a problem hiding this comment.
Will you please remove this in a separate commit?
| @@ -184,7 +184,7 @@ public void doFilterWhenRelyingPartyRegistrationRepositoryConstructorAndPathStar | |||
| public void doFilterWhenCharacterEncodingThenEncodeSpecialCharactersCorrectly() throws Exception { | |||
| RelyingPartyRegistration validRegistration = TestRelyingPartyRegistrations.full().build(); | |||
| String testMetadataFilename = "test-{registrationId}-metadata.xml"; | |||
| String generatedMetadata = "<xml>testäöü</xml>"; | |||
| String generatedMetadata = "<xml>test���</xml>"; | |||
There was a problem hiding this comment.
Is this change intended? Can we leave it as-is?
| @@ -44,7 +44,7 @@ | |||
| * String registrationId = "simplesamlphp"; | |||
| * | |||
| * String relyingPartyEntityId = "{baseUrl}/saml2/service-provider-metadata/{registrationId}"; | |||
| * String assertionConsumerServiceLocation = "{baseUrl}/login/saml2/sso/{registrationId}"; | |||
| * String assertingConsumerServiceLocation = "{baseUrl}/login/saml2/sso/{registrationId}"; | |||
There was a problem hiding this comment.
Thank you for the typo cleanups. Will you please place these in a separate commit?
jzheaux
added
type: enhancement
ngocnhan-tran1996
force-pushed
the
gh-17305
branch
2 times, most recently
from
a3c2ca8 to
d384044
Compare
|
Thanks for your feedback. I've updated it. |
Signed-off-by: Tran Ngoc Nhan <[email protected]>
Signed-off-by: Tran Ngoc Nhan <[email protected]>
Signed-off-by: Tran Ngoc Nhan <[email protected]>
Signed-off-by: Tran Ngoc Nhan <[email protected]>
ngocnhan-tran1996
force-pushed
the
gh-17305
branch
from
66d176f to
b91034f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-17305