Use LdapName instead of DistinguishedName
#17325
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
requested changes
Jun 24, 2025
There was a problem hiding this comment.
Thanks, @therepanic! I've left some feedback inline.
In addition to that feedback, will you please place the ticket number in the description instead of the title, like so:
Use LdapName instead of DistinguishedName
Closes gh-17301
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2002-2013 the original author or authors. | |||
| * Copyright 2002-2025 the original author or authors. | |||
There was a problem hiding this comment.
Since this file didn't have any code changes in the end, will you please remove it from the PR?
| @@ -96,44 +96,6 @@ public class RelyingPartyRegistration implements Serializable { | |||
| private final Collection<Saml2X509Credential> signingX509Credentials; | |||
|
|
|||
| protected RelyingPartyRegistration(String registrationId, String entityId, String assertionConsumerServiceLocation, | |||
There was a problem hiding this comment.
Will you please remove this? I believe there is a separate PR taking care of RelyingPartyRegistration.
There was a problem hiding this comment.
I apologize, I don't know how it got here.
jzheaux
added
in: ldap
Closes spring-projectsgh-17301 Signed-off-by: Andrey Litvitski <[email protected]>
|
I assume the build tests are failing not because of my changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #17301