Create CsrfCustomizer for SPA configuration (#14149) #16966
+109
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
…4149) Signed-off-by: Felix Hagemans <[email protected]>
felhag
force-pushed
the
feature/114149-spa-csrf
branch
from
fb322f9 to
8d09a9a
Compare
jzheaux
requested changes
Apr 23, 2025
There was a problem hiding this comment.
Great idea, @felhag. It would be nice for the DSL to put this together for applications. I've left some feedback inline.
Note that I likely won't comment on this again until 6.5 releases, but I wanted to get you some feedback so that you aren't waiting on me.
...main/java/org/springframework/security/config/annotation/web/configurers/CsrfCustomizer.java
Outdated
Show resolved
Hide resolved
...main/java/org/springframework/security/config/annotation/web/configurers/CsrfCustomizer.java
Outdated
Show resolved
Hide resolved
...main/java/org/springframework/security/config/annotation/web/configurers/CsrfCustomizer.java
Outdated
Show resolved
Hide resolved
...main/java/org/springframework/security/config/annotation/web/configurers/CsrfCustomizer.java
Outdated
Show resolved
Hide resolved
...java/org/springframework/security/config/annotation/web/configurers/CsrfConfigurerTests.java
Outdated
Show resolved
Hide resolved
felhag
force-pushed
the
feature/114149-spa-csrf
branch
from
1740373 to
d72b57d
Compare
Signed-off-by: Felix Hagemans <[email protected]>
felhag
force-pushed
the
feature/114149-spa-csrf
branch
from
d72b57d to
ec53749
Compare
|
Hey @jzheaux, thanks for your time. Processed your comments in a new commit (I assume it is squashed anyways when merged). Renamed the method to just And also updated the documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.