Skip to content

Pr 16635 last version #16899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Pr 16635 last version #16899

wants to merge 3 commits into from
+657 −41

Conversation

GuusArts
Copy link

@GuusArts GuusArts commented Apr 7, 2025

No description provided.

pat-mccusker and others added 3 commits March 18, 2025 15:56
@pat-mccusker @jzheaux
Add the MatchResult class to MessageMatcher

Verified

This commit was signed with the committer’s verified signature.
jzheaux Josh Cummings
GPG key ID: 869B37A20E876129
Verified
Learn about vigilant mode
44665c1 
Closes spring-projectsgh-16766

Signed-off-by: Pat McCusker <[email protected]>
@pat-mccusker @jzheaux
Add PathPatternMessageMatcher

Verified

This commit was signed with the committer’s verified signature.
jzheaux Josh Cummings
GPG key ID: 869B37A20E876129
Verified
Learn about vigilant mode
7cc8706 
Closes spring-projectsgh-16500

Signed-off-by: Pat McCusker <[email protected]>
@jzheaux
PathPatternMessageMatcher Polish

Verified

This commit was signed with the committer’s verified signature.
jzheaux Josh Cummings
GPG key ID: 869B37A20E876129
Verified
Learn about vigilant mode
Loading
Loading status checks…
949d1cc 
Issue spring-projectsgh-16500

Signed-off-by: Josh Cummings <[email protected]>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 7, 2025
@jzheaux
Copy link
Contributor

jzheaux commented Apr 23, 2025

Hi, @GuusArts, thanks for reaching out. I wanted to make sure that I didn't miss something; however, these commits were merged in March. When I rebased your branch locally with main, I got:

warning: skipped previously applied commit 44665c1548
warning: skipped previously applied commit 7cc8706611
warning: skipped previously applied commit 949d1cca36

Is there something that I've misunderstood about what the PR is for?

@jzheaux jzheaux self-assigned this Apr 23, 2025
@jzheaux jzheaux added status: waiting-for-feedback We need additional information before we can continue status: invalid An issue that we don't feel is valid in: messaging An issue in spring-security-messaging and removed status: waiting-for-triage An issue we've not yet triaged status: waiting-for-feedback We need additional information before we can continue labels Apr 23, 2025
@jzheaux
Copy link
Contributor

jzheaux commented Apr 29, 2025

I'm going to guess that this PR was submitted by mistake. As such I'll close it as a duplicate of #16635

@GuusArts please feel free to reach out if I'm mistaken.

@jzheaux jzheaux closed this Apr 29, 2025
@jzheaux jzheaux added status: duplicate A duplicate of another issue and removed status: invalid An issue that we don't feel is valid labels Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jzheaux jzheaux

Labels
in: messaging An issue in spring-security-messaging status: duplicate A duplicate of another issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GuusArts @jzheaux @spring-projects-issues @pat-mccusker