Stop shading checker-qual in caffeine cache provider (2.0.x line) #1179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adjusts the shading in the spring-pulsar-cache-provider-caffeine module to not include the `org.checkerframework:checker-qual` in the shaded jar. Signed-off-by: Chris Bono <[email protected]>
onobc
commented
Jul 17, 2025
| @@ -23,10 +23,9 @@ shadowJar { | |||
| } | |||
| relocate 'com.github.benmanes.caffeine', 'org.springframework.pulsar.shade.com.github.benmanes.caffeine' | |||
| relocate 'com.google', 'org.springframework.pulsar.shade.com.google' | |||
| relocate 'org.checkerframework', 'org.springframework.pulsar.shade.org.checkerframework' | |||
There was a problem hiding this comment.
Eventhough main is on caffeine 3.2.1 which no longer includes org.checkerframework this is just dead code that needs to be removed.
|
@mbhave PTAL |
onobc
added
the
type: improvement
onobc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adjusts the shading in the spring-pulsar-cache-provider-caffeine module to not include the
org.checkerframework:checker-qualin the shaded jar.