Skip to content

#1058: Migrate test-support Module to JUnit5 #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

#1058: Migrate test-support Module to JUnit5 #1171

wants to merge 2 commits into from

Conversation

etrandafir93
Copy link
Contributor

implements #1058

@etrandafir93
migrate to junit5
38be600 
Issue spring-projects#1058

Signed-off-by: etrandafir93 <[email protected]>
@etrandafir93
tidy tests
6204576 
Issue spring-projects#1058

Signed-off-by: etrandafir93 <[email protected]>
@etrandafir93
Copy link
Contributor Author

hey @jzheaux, here's my PR!

I've used the org.springframework.util.Assert here instead of a JUnit-specific one, which I think is much better because we no longer need JUnit as a provided dependency - now removed.

Apart from this, I have performed some minor refactoring of the tests and assertions (see the 2nd commit).
Let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@etrandafir93