Apply NullAbility to MQTT module #10274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artembilan
requested changes
Jul 31, 2025
| Message<?> toMessage(byte[] bytes, @Nullable Map<String, Object> headers); | ||
|
|
||
| @Override | ||
| byte @NonNull [] fromMessage(Message<?> message); |
There was a problem hiding this comment.
We don’t need @NonNull at all.
artembilan
requested changes
Aug 1, 2025
| @@ -34,7 +36,7 @@ public class MqttMessageNotDeliveredEvent extends MqttMessageDeliveryEvent { | |||
|
|
|||
| private final Throwable exception; | |||
|
|
|||
| public MqttMessageNotDeliveredEvent(Object source, int messageId, String clientId, | |||
| public MqttMessageNotDeliveredEvent(Object source, int messageId, @Nullable String clientId, | |||
There was a problem hiding this comment.
I think we need to revise clientId. It is not null this or other way.
See AbstractMqttClientManager.getClientId().
We should utilize that in the AbstractMqttMessageHandler.getClientId() as an if..else to return provided clientId or the one supplied by the clientManager
There was a problem hiding this comment.
indeed. i extract getClientId() to the top ClientManager interface. also getUrl().
for inbound/outbound adapters, in their ctors, if url/client not provided, will be assigned from the clientManager.
...va/org/springframework/integration/mqtt/inbound/AbstractMqttMessageDrivenChannelAdapter.java
Show resolved
Hide resolved
...n/java/org/springframework/integration/mqtt/inbound/MqttPahoMessageDrivenChannelAdapter.java
Outdated
Show resolved
Hide resolved
Related to: spring-projects#10083 Signed-off-by: Jiandong Ma <[email protected]>
Signed-off-by: Jiandong Ma <[email protected]>
Signed-off-by: Jiandong Ma <[email protected]>
artembilan
requested changes
Aug 4, 2025
...n/java/org/springframework/integration/mqtt/inbound/MqttPahoMessageDrivenChannelAdapter.java
Outdated
Show resolved
Hide resolved
...java/org/springframework/integration/mqtt/inbound/Mqttv5PahoMessageDrivenChannelAdapter.java
Outdated
Show resolved
Hide resolved
...java/org/springframework/integration/mqtt/inbound/Mqttv5PahoMessageDrivenChannelAdapter.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/springframework/integration/mqtt/outbound/AbstractMqttMessageHandler.java
Outdated
Show resolved
Hide resolved
suppress with NullAway for `toMessageBuilder` in v3 inbound adapter. Signed-off-by: Jiandong Ma <[email protected]>
…gration into jspecify-mqtt
artembilan
requested changes
Aug 4, 2025
...n/java/org/springframework/integration/mqtt/inbound/MqttPahoMessageDrivenChannelAdapter.java
Outdated
Show resolved
Hide resolved
...n/java/org/springframework/integration/mqtt/inbound/MqttPahoMessageDrivenChannelAdapter.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jiandong Ma <[email protected]>
…gration into jspecify-mqtt
artembilan
requested changes
Aug 4, 2025
...-integration-mqtt/src/main/java/org/springframework/integration/mqtt/core/ClientManager.java
Show resolved
Hide resolved
Signed-off-by: Jiandong Ma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #10083