Test escape character support in PropertySourcesPropertyResolver
#34720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes-34326 Signed-off-by: Fawzi Essam <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
the
in: core
sbrannen
changed the title
PropertySourcesPropertyResolver
sbrannen
added
type: task
sbrannen
pushed a commit
that referenced
this pull request
May 9, 2025
See gh-34326 See gh-34720 See gh-34861 Signed-off-by: Fawzi Essam <[email protected]>
sbrannen
added a commit
that referenced
this pull request
May 9, 2025
|
Hi @iifawzi, Congratulations on submitting your first PR for the Spring Framework! 👍 Please note that your tests pass without any changes to As I have outlined in #34861, the core of the problem lies in the implementation of However, your proposed tests are still good to have in place. Thus, I merged them in 9b52cfd without the changes to Thanks for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this PR aims to resolve #34326.
Added a new utility method
resolveNestedPlaceholdersWithEscapePreservation, to preserve escaped placeholders using a regex pattern\\(\$\{[^}]+\}), which then masks it and then restores the placeholder after the call toresolveNestedPlaceholdersThis is my first contribution to the project, so I might be missing something, let me know if you think I can help in doing it in any different way.