Skip to content

Add support for XDELEX and XACKDEL, and expand options for XADD and XTRIM #3247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add support for XDELEX and XACKDEL, and expand options for XADD and XTRIM #3247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6cbbe1
Expand XADD and XTRIM with exact trimming, limit and deletion policy.
viktoriya-kutsarova Oct 16, 2025
cb6b9f7
Add XACKDEL and XDELEX commands support.
viktoriya-kutsarova Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/main/antora/modules/ROOT/pages/appendix.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,22 @@ link:https://www.springframework.org/schema/redis/spring-redis-1.0.xsd[Spring Da
|UNSUBSCRIBE |X
|UNWATCH |X
|WATCH |X
|XACK |X
|XACKDEL |X
|XADD |X
|XAUTOCLAIM |X
|XCLAIM |X
|XDEL |X
|XDELEX |X
|XGROUP |X
|XINFO |X
|XLEN |X
|XPENDING |X
|XRANGE |X
|XREAD |X
|XREADGROUP |X
|XREVRANGE |X
|XTRIM |X
|ZADD |X
|ZCARD |X
|ZCOUNT |X
Expand Down
32 changes: 32 additions & 0 deletions src/main/java/org/springframework/data/redis/connection/DefaultStringRedisConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2905,6 +2905,18 @@ public Long xDel(String key, RecordId... recordIds) {
return convertAndReturn(delegate.xDel(serialize(key), recordIds), Converters.identityConverter());
}

@Override
public List<StreamEntryDeletionResult> xDelEx(String key, XDelOptions options, RecordId... recordIds) {
return convertAndReturn(delegate.xDelEx(serialize(key), options, recordIds),
Converters.identityConverter());
}

@Override
public List<StreamEntryDeletionResult> xAckDel(String key, String group, XDelOptions options, RecordId... recordIds) {
return convertAndReturn(delegate.xAckDel(serialize(key), group, options, recordIds),
Converters.identityConverter());
}

@Override
public String xGroupCreate(String key, ReadOffset readOffset, String group) {
return convertAndReturn(delegate.xGroupCreate(serialize(key), group, readOffset), Converters.identityConverter());
Expand Down Expand Up @@ -3021,6 +3033,11 @@ public Long xTrim(String key, long count, boolean approximateTrimming) {
return convertAndReturn(delegate.xTrim(serialize(key), count, approximateTrimming), Converters.identityConverter());
}

@Override
public Long xTrim(String key, XTrimOptions options) {
return convertAndReturn(delegate.xTrim(serialize(key), options), Converters.identityConverter());
}

@Override
public Long xAck(byte[] key, String group, RecordId... recordIds) {
return delegate.xAck(key, group, recordIds);
Expand All @@ -3046,6 +3063,16 @@ public Long xDel(byte[] key, RecordId... recordIds) {
return delegate.xDel(key, recordIds);
}

@Override
public List<StreamEntryDeletionResult> xDelEx(byte[] key, XDelOptions options, RecordId... recordIds) {
return delegate.xDelEx(key, options, recordIds);
}

@Override
public List<StreamEntryDeletionResult> xAckDel(byte[] key, String group, XDelOptions options, RecordId... recordIds) {
return delegate.xAckDel(key, group, options, recordIds);
}

@Override
public String xGroupCreate(byte[] key, String groupName, ReadOffset readOffset) {
return delegate.xGroupCreate(key, groupName, readOffset);
Expand Down Expand Up @@ -3129,6 +3156,11 @@ public Long xTrim(byte[] key, long count, boolean approximateTrimming) {
return delegate.xTrim(key, count, approximateTrimming);
}

@Override
public Long xTrim(byte[] key, XTrimOptions options) {
return delegate.xTrim(key, options);
}

/**
* Specifies if pipelined and tx results should be deserialized to Strings. If false, results of
* {@link #closePipeline()} and {@link #exec()} will be of the type returned by the underlying connection
Expand Down
22 changes: 22 additions & 0 deletions src/main/java/org/springframework/data/redis/connection/DefaultedRedisConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,6 +550,20 @@ default Long xDel(byte[] key, RecordId... recordIds) {
return streamCommands().xDel(key, recordIds);
}

/** @deprecated in favor of {@link RedisConnection#streamCommands()}}. */
@Override
@Deprecated
default List<StreamEntryDeletionResult> xDelEx(byte[] key, XDelOptions options, RecordId... recordIds) {
return streamCommands().xDelEx(key, options, recordIds);
}

/** @deprecated in favor of {@link RedisConnection#streamCommands()}}. */
@Override
@Deprecated
default List<StreamEntryDeletionResult> xAckDel(byte[] key, String group, XDelOptions options, RecordId... recordIds) {
return streamCommands().xAckDel(key, group, options, recordIds);
}

/** @deprecated in favor of {@link RedisConnection#streamCommands()}}. */
@Override
@Deprecated
Expand Down Expand Up @@ -686,12 +700,20 @@ default Long xTrim(byte[] key, long count) {
return xTrim(key, count, false);
}

/** @deprecated in favor of {@link RedisConnection#streamCommands()}}. */
@Override
@Deprecated
default Long xTrim(byte[] key, long count, boolean approximateTrimming) {
return streamCommands().xTrim(key, count, approximateTrimming);
}

/** @deprecated in favor of {@link RedisConnection#streamCommands()}}. */
@Override
@Deprecated
default Long xTrim(byte[] key, XTrimOptions options) {
return streamCommands().xTrim(key, options);
}

// LIST COMMANDS

/** @deprecated in favor of {@link RedisConnection#listCommands()}}. */
Expand Down
Loading