-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Document usage scope and effects of Meta annotation #4854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
LGTM |
We now allow applying Meta to derived queries without turning a derived query method into a annotated one.
schauder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one question about the changes
| * @param lastname | ||
| * @return | ||
| */ | ||
| @Meta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this here? Seems like it was intended to be part of a Meta related test, but the test didn't make it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an leftover from research on the actual behavior, it can be removed.
|
That's merged and back ported. |
Closes #4852