Backport Specification.unrestricted() #3940
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-gruber
commented
Jul 14, 2025
r-gruber
commented
- You have read the Spring Data contribution guidelines.
- You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
- You submit test cases (unit or integration tests) that back your changes.
- You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
Also, document the intent to make methods accepting `Specifications` to be non-nullable. Closes spring-projects#3893
We now exclude `?&` and `?|` from being matched as JDBC-style parameter bind marker. Closes spring-projects#3907
We now no longer attempt to rewrite the query if the target type doesn't define input properties (no-args constructor or multiple constructors). Closes spring-projects#3895
We now back off from rewriting queries to constructor expressions if a returned type is a JPA-managed one. See spring-projects#3895
We now consider dropping aliases (count(foo) as foo), support subselects and capture individual select items to avoid contextual information loss. Also, added a series of tests to cover edgecases. See spring-projects#3895
We now only consider top-level properties for tuple query selection to avoid join products caused by selecting nested relationships. Closes spring-projects#3908
Signed-off-by: Aref <[email protected]> Closes: spring-projects#3901
Move warning suppression to the class-level. See spring-projects#3901
Signed-off-by: Ariel Morelli Andres <[email protected]> Closes: spring-projects#3425 Original pull request: spring-projects#3885
Revise PersistenceProvider detection to a EntityManagerFactory-based variant, considering EntityManagerFactory proxying. See: spring-projects#3425 Original pull request: spring-projects#3885
Remove leading space requirement, simplify group nesting and replace character class with non-capturing group to avoid a, s and | (pipe) matching. Closes spring-projects#3911
Remove type parameter to enable usage with Hibernate 6.2. See: spring-projects#3425 Original pull request: spring-projects#3885
Signed-off-by: hoyeon Jang <[email protected]> Closes spring-projects#3912
Simplify regex. See spring-projects#3911
Refine readme. See spring-projects#3892
We now distinguish between Spring-proxied and other JDK proxied EntityManagerFactory objects for proper unwrapping. Spring consistently uses a null value as class to get hold of the target object. Both, Hibernate and EclipseLink fail with a NullPointerException when calling unwrap(null) and therefore, we call all other JDK proxies with unwrap(EntityManagerFactory.class) to adhere to the JPA specification and avoid failures according to the implementations. Any other proxying mechanism that behaves differently will require additional refinement once such a case comes up. Closes spring-projects#3923
Remove additional Eclipselink build steps as we don't use these. See spring-projects#3892
…writing. We now verify that we can actually express a valid constructor expression before rewriting queries to use constructor expressions. See spring-projects#3929
…tion. Signed-off-by: Giheon Do <[email protected]> Closes spring-projects#3932
Refine conditional flow. See spring-projects#3932
Cache the deleteAll and count query strings as final fields in SimpleJpaRepository. This avoids repeated String.format operations and reduces unnecessary object creation on every invocation of deleteAllInBatch() and count(). No functional changes. Signed-off-by: Giheon Do <[email protected]> Closes spring-projects#3920
Inline methods, lazify query creation. See spring-projects#3920
This would allow 3.5 users to rework their code ahead of the 4.0 release. 'where(null)' was deprecated and should be replaced with unrestricted()
spring-projects-issues
added
the
status: waiting-for-triage
|
Sorry, i miss clicked to wrong target branch :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.