Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpaged pageable maybe have Sort #2718

Closed
wants to merge 1 commit into from

Conversation

jiayp
Copy link

@jiayp jiayp commented Dec 2, 2022

Unpaged pageable maybe have Sort.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Unpaged pageable maybe have Sort.
@pivotal-cla
Copy link

@jiayp Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 2, 2022
@pivotal-cla
Copy link

@jiayp Thank you for signing the Contributor License Agreement!

@mp911de
Copy link
Member

mp911de commented Dec 2, 2022

Pageable.unpaged() is a substitute for null. Previously, we accepted null as parameter for Pageable. Following that line of thought, there would not be a Sort associated with a null Pageable.

@mp911de mp911de added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 2, 2022
@mp911de
Copy link
Member

mp911de commented Dec 2, 2022

Duplicate of #2691

@mp911de mp911de marked this as a duplicate of #2691 Dec 2, 2022
@mp911de mp911de closed this Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants