Handle Docker 407 (Proxy Authentication Required) with clear error message #47180
+133
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
requested changes
Sep 18, 2025
|
|
||
| String detail = null; | ||
| Message json = deserializeMessage(content); | ||
| if (json != null && org.springframework.util.StringUtils.hasText(json.getMessage())) { |
There was a problem hiding this comment.
StringUtils is already imported so there's no need to fully-qualify the type.
|
|
||
| String msg = "Proxy authentication required for host: " + this.host.toHostString() + ", uri: " | ||
| + request.getUri() | ||
| + (org.springframework.util.StringUtils.hasText(detail) ? " - " + detail : ""); |
There was a problem hiding this comment.
StringUtils is already imported so there's no need to fully-qualify the type.
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| class ProxyAuthenticationExceptionTests { |
There was a problem hiding this comment.
I don't think we need tests for ProxyAuthenticationException. Please remove this class.
| detail = json.getMessage(); | ||
| } | ||
| else { | ||
| detail = new String(content, java.nio.charset.StandardCharsets.UTF_8); |
There was a problem hiding this comment.
StandardCharsets should be imported rather than using the fully-qualified type here.
|
Also, please sign your commits as described in the DCO check failure. |
wilkinsona
reviewed
Sep 18, 2025
| response.close(); | ||
|
|
||
| if (statusCode == 407) { | ||
| response.close(); |
There was a problem hiding this comment.
This looks wrong to me as the response will now only be closed when the status code is 407.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When Docker returns 407 (Proxy Authentication Required), the response is often plain text, so the current code fails to surface a helpful error.
Solution
Tests
Notes
Fixes: #46262