Failure to discover default value for a primitive should not lead to document its default value #46551
+104
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation metadata Signed-off-by: Now <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
This was referenced Jul 25, 2025
snicoll
added
type: bug
snicoll
changed the title
snicoll
pushed a commit
that referenced
this pull request
Jul 28, 2025
See gh-46551 Signed-off-by: Now <[email protected]>
snicoll
added a commit
that referenced
this pull request
Jul 28, 2025
|
Thanks again @Kguswo, see the polish commit for the things I've amended. |
|
Thanks! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Improve configuration metadata annotation processor to omit unknown default values in arithmetic expressions.
As arithmetic expressions are not considered literals by the processor, their default values should not be recorded in the generated metadata. This change updates the processor to properly omit such values and adds tests to verify the behavior.
Open to suggestions or corrections!
Related Issue
#46509