Skip to content

HealthEndpointAutoConfigurationTests should not rely on CloudFoundry #45731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

kwondh5217
Copy link
Contributor

@kwondh5217 kwondh5217 commented May 31, 2025

This PR avoids relying on Cloud Foundry exposure logic in HealthEndpointAutoConfigurationTests.

See gh-45721

This avoids relying on Cloud Foundry exposure logic in
HealthEndpointAutoConfigurationTests.

See spring-projectsgh-45721

Signed-off-by: Daeho Kwon <[email protected]>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 31, 2025
Signed-off-by: Daeho Kwon <[email protected]>
@wilkinsona
Copy link
Member

The goal of #45721 is to stop using the CloudFoundry's EndpointExposureOutcomeContributor in the tests, not to move that usage into a different class. To do so will probably require a test-specific EndpointExposureOutcomeContributor implementation. Thanks anyway for the PR.

@wilkinsona wilkinsona closed this May 31, 2025
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants