Skip to content

AutoConfiguredRestClientSsl should build upon, rather than overwrite, the configuration from HttpClientProperties #44979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nosan
Copy link
Contributor

@nosan nosan commented Apr 2, 2025

See gh-43618

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 2, 2025
Prior to this commit, RestClientSsl always used the
default settings from ClientHttpRequestFactorySettings, overriding any
user-defined settings (e.g., HttpClientProperties).

With this commit, RestClientSsl now respects and uses
ClientHttpRequestFactorySettings when they are provided.

Signed-off-by: Dmytro Nosan <[email protected]>
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 15, 2025
@philwebb philwebb added this to the 3.5.0-RC1 milestone Apr 15, 2025
@philwebb philwebb self-assigned this Apr 15, 2025
philwebb pushed a commit that referenced this pull request Apr 15, 2025
Prior to this commit, RestClientSsl always used the
default settings from ClientHttpRequestFactorySettings, overriding any
user-defined settings (e.g., HttpClientProperties).

With this commit, RestClientSsl now respects and uses
ClientHttpRequestFactorySettings when they are provided.

See gh-44979

Signed-off-by: Dmytro Nosan <[email protected]>
@philwebb philwebb closed this in 2f30c52 Apr 15, 2025
@philwebb
Copy link
Member

Thanks very much @nosan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants