Skip to content

Refactor JDBC DAOs to use JdbcClient where feasible #4897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor JDBC DAOs to use JdbcClient where feasible #4897

wants to merge 1 commit into from

Conversation

@quaff
Copy link
Contributor

@quaff quaff commented Jul 1, 2025

Closes GH-4804

@quaff quaff marked this pull request as draft July 1, 2025 02:18
@quaff quaff marked this pull request as ready for review July 1, 2025 02:52
@quaff
Copy link
Contributor Author

quaff commented Jul 1, 2025

JdbcTemplate is only used for batch update which is not covered by JdbcClient.

@quaff quaff force-pushed the patch-21 branch 2 times, most recently from 8124810 to 789e94d Compare July 1, 2025 03:35
@fmbenhassine fmbenhassine added this to the 6.0.0-RC1 milestone Sep 11, 2025
@fmbenhassine
Copy link
Contributor

JdbcTemplate is only used for batch update which is not covered by JdbcClient.

It's unfortunate to have to use JdbcClient and JdbcTemplate at the same time. In hindsight, do you think there is an added value in using JdbcClient if we can't remove the usage of JdbcTemplate altogether (I mean a 100% replacement)?

@fmbenhassine fmbenhassine removed this from the 6.0.0-RC1 milestone Oct 21, 2025
@fmbenhassine fmbenhassine added the status: waiting-for-reporter Issues for which we are waiting for feedback from the reporter label Oct 21, 2025
@quaff
Copy link
Contributor Author

quaff commented Oct 22, 2025

JdbcTemplate is only used for batch update which is not covered by JdbcClient.

It's unfortunate to have to use JdbcClient and JdbcTemplate at the same time. In hindsight, do you think there is an added value in using JdbcClient if we can't remove the usage of JdbcTemplate altogether (I mean a 100% replacement)?

Let's wait for spring-projects/spring-framework#33843

@fmbenhassine fmbenhassine added status: feedback-provided Issues for which the feedback requested from the reporter was provided and removed status: waiting-for-reporter Issues for which we are waiting for feedback from the reporter labels Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmbenhassine fmbenhassine fmbenhassine left review comments

Assignees

No one assigned

Labels

status: feedback-provided Issues for which the feedback requested from the reporter was provided

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor JDBC DAOs to use named parameters instead of positional parameters

2 participants

@quaff @fmbenhassine