Migrate to JSpecify annotations for nullability constraints #4864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scordio
force-pushed
the
jspecify
branch
7 times, most recently
from
35c9da1 to
c737967
Compare
Signed-off-by: Stefano Cordio <[email protected]>
Signed-off-by: Stefano Cordio <[email protected]>
This executed: ``` mvn -U org.openrewrite.maven:rewrite-maven-plugin:run -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-migrate-java:RELEASE -Drewrite.activeRecipes=org.openrewrite.java.jspecify.MigrateFromSpringFrameworkAnnotations,org.openrewrite.staticanalysis.AnnotateNullableMethods,org.openrewrite.staticanalysis.NullableOnMethodReturnType -Drewrite.exportDatatables=true ``` Signed-off-by: Stefano Cordio <[email protected]>
Signed-off-by: Stefano Cordio <[email protected]>
Signed-off-by: Stefano Cordio <[email protected]>
scordio
force-pushed
the
jspecify
branch
2 times, most recently
from
38292b1 to
fee88d7
Compare
Signed-off-by: Stefano Cordio <[email protected]>
scordio
commented
Jun 26, 2025
Comment on lines
-190
to
-228
| -Xep:AlmostJavadoc:OFF | ||
| -Xep:ByteBufferBackingArray:OFF | ||
| -Xep:ClassCanBeStatic:OFF | ||
| -Xep:CollectionUndefinedEquality:OFF | ||
| -Xep:DefaultCharset:OFF | ||
| -Xep:DirectInvocationOnMock:OFF | ||
| -Xep:DoNotCallSuggester:OFF | ||
| -Xep:EmptyCatch:OFF | ||
| -Xep:EqualsGetClass:OFF | ||
| -Xep:Finally:OFF | ||
| -Xep:FutureReturnValueIgnored:OFF | ||
| -Xep:HidingField:OFF | ||
| -Xep:ImmutableEnumChecker:OFF | ||
| -Xep:InlineMeSuggester:OFF | ||
| -Xep:InputStreamSlowMultibyteRead:OFF | ||
| -Xep:JavaTimeDefaultTimeZone:OFF | ||
| -Xep:JavaUtilDate:OFF | ||
| -Xep:JdkObsolete:OFF | ||
| -Xep:MissingSummary:OFF | ||
| -Xep:MixedMutabilityReturnType:OFF | ||
| -Xep:MutablePublicArray:OFF | ||
| -Xep:NonAtomicVolatileUpdate:OFF | ||
| -Xep:RedundantControlFlow:OFF | ||
| -Xep:ReferenceEquality:OFF | ||
| -Xep:StaticAssignmentInConstructor:OFF | ||
| -Xep:StaticAssignmentOfThrowable:OFF | ||
| -Xep:StaticMockMember:OFF | ||
| -Xep:StreamResourceLeak:OFF | ||
| -Xep:StringCaseLocaleUsage:OFF | ||
| -Xep:StringSplitter:OFF | ||
| -Xep:SynchronizeOnNonFinalField:OFF | ||
| -Xep:ThreadLocalUsage:OFF | ||
| -Xep:ThreadPriorityCheck:OFF | ||
| -Xep:TypeParameterUnusedInFormals:OFF | ||
| -Xep:UndefinedEquals:OFF | ||
| -Xep:UnnecessaryStringBuilder:OFF | ||
| -Xep:UnusedMethod:OFF | ||
| -Xep:UnusedVariable:OFF | ||
| -Xep:WaitNotInLoop:OFF |
There was a problem hiding this comment.
As per discussion at 72694e6#commitcomment-159565537
| HippyMethodInvoker invoker = new HippyMethodInvoker(); | ||
| invoker.setTargetObject(targetObject); | ||
| invoker.setTargetMethod(targetMethod); | ||
| invoker.setArguments(arguments); | ||
| invoker.setArguments(arguments); // FIXME spring-projects/spring-framework#35089 |
There was a problem hiding this comment.
Depends on spring-projects/spring-framework#35089
| MethodInvoker invoker = createMethodInvoker(targetObject, targetMethod); | ||
| invoker.setArguments(arguments); | ||
| invoker.setArguments(arguments); // FIXME spring-projects/spring-framework#35089 |
There was a problem hiding this comment.
Depends on spring-projects/spring-framework#35089
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change also introduces NullAway to verify that all code is correctly annotated.