Skip to content

Fix javadoc in JdbcCursorItemReaderBuilder #4838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2025
Merged

Fix javadoc in JdbcCursorItemReaderBuilder #4838

merged 1 commit into from
Jun 3, 2025

Conversation

itis821
Copy link
Contributor

@itis821 itis821 commented May 8, 2025

  • JdbcCursorItemReaderBuilder.queryTimeout(int) -> milliseconds
  • but, AbstractCursorItemReader.setQueryTimeout(int) -> seconds

@itis821
Fix javadoc in JdbcCursorItemReaderBuilder
3d20632 
  - JdbcCursorItemReaderBuilder.queryTimeout(int) -> milliseconds
  - but, AbstractCursorItemReader.setQueryTimeout(int) -> seconds

Signed-off-by: Jisu Lee <[email protected]>
@itis821
Copy link
Contributor Author

itis821 commented May 8, 2025

JdbcCursorItemReaderBuilder's build() method calls JdbcCursorItemReader.setQueryTimeout(int). This setQueryTimeout(int) method is actually defined in AbstractCursorItemReader.setQueryTimeout(int). Therefore, the queryTimeout parameter from JdbcCursorItemReaderBuilder is passed as an argument to AbstractCursorItemReader.setQueryTimeout(). However, there's an issue where the javadoc specifies different units for this timeout value between JdbcCursorItemReaderBuilder and AbstractCursorItemReader.

@fmbenhassine
Copy link
Contributor

That's incorrect, good catch! I will rebase and merge your PR. Thank you for your contribution 👍

@fmbenhassine fmbenhassine added pr-for: bug in: documentation for: backport-to-5.2.x Issues that will be back-ported to the 5.2.x line labels Jun 3, 2025
@fmbenhassine fmbenhassine added this to the 6.0.0-M1 milestone Jun 3, 2025
@fmbenhassine fmbenhassine merged commit 74de2e8 into spring-projects:main Jun 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
for: backport-to-5.2.x Issues that will be back-ported to the 5.2.x line in: documentation pr-for: bug
Projects
None yet
Milestone
6.0.0-M1
Development

Successfully merging this pull request may close these issues.
2 participants
@itis821 @fmbenhassine