Jspecify part 3: chat-client + vector-store #5183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericbottard
force-pushed
the
jspecify-3
branch
from
27004e7 to
c57dd3b
Compare
sdeleuze
reviewed
Jan 6, 2026
...lient-chat/src/main/java/org/springframework/ai/chat/client/ChatClientMessageAggregator.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| public Builder context(Map<String, Object> context) { | ||
| public Builder context(Map<String, @Nullable Object> context) { |
Contributor
There was a problem hiding this comment.
If we want to accept both Map<String, @Nullable Object> and Map<String, Object> in null-marked code, it should be Map<String, ? extends @Nullable Object>. Is forcing Map<String, @Nullable Object> done on purpose here?
| * @since 1.0.0 | ||
| */ | ||
| public record ChatClientResponse(@Nullable ChatResponse chatResponse, Map<String, Object> context) { | ||
| public record ChatClientResponse(@Nullable ChatResponse chatResponse, Map<String, @Nullable Object> context) { |
Contributor
There was a problem hiding this comment.
Same question as above, do we want Map<String, ? extends @Nullable Object> or Map<String, @Nullable Object> here?
Signed-off-by: Eric Bottard <[email protected]>
Signed-off-by: Eric Bottard <[email protected]>
ericbottard
force-pushed
the
jspecify-3
branch
from
c57dd3b to
e688693
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.