feat(memory): Add Sqlite support for JDBC chat memory(#4698) #4698
+102
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng-projects#4698) - Add Oracle and Sqlite JdbcChatMemoryRepositoryDialect classes. - Modify the JdbcChatMemoryRepositoryDialect interface to support identifying the correct dialect for Oracle and SQLite by their database product names. - Add Oracle and Sqlite JdbcChatMemoryRepository integration test classes. Signed-off-by: guanxu <[email protected]>
|
@guanxuc Thanks for the PR! There is an existing PR adding Oracle chat memory support #3601 by @fanxt0218. |
Signed-off-by: guanxu <[email protected]>
guanxuc
changed the title
@ilayaperumalg Thanks for your review! I have removed Oracle related duplicate code, and then only keep Sqlite related code. |
Signed-off-by: guanxu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.