AOT refinements for M7 #2664
Closed
AOT refinements for M7 #2664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Long <[email protected]>
Signed-off-by: Josh Long <[email protected]>
| @@ -42,6 +42,8 @@ | |||
| import org.springframework.ai.openai.api.OpenAiApi.EmbeddingList; | |||
| import org.springframework.ai.openai.api.common.OpenAiApiConstants; | |||
| import org.springframework.ai.retry.RetryUtils; | |||
| import org.springframework.aot.hint.RuntimeHints; | |||
There was a problem hiding this comment.
will clean this up when merging.
| @@ -40,23 +35,13 @@ | |||
| */ | |||
| public class OpenAiRuntimeHints implements RuntimeHintsRegistrar { | |||
There was a problem hiding this comment.
@joshlong what is the reasoning behind removing the OpenAI API types and just adding the OpenAIChatOptions here?
There was a problem hiding this comment.
It can not hurt to add them. please do.
There was a problem hiding this comment.
sure, I will add them back and merge.
|
Re-added OpenAI API packages, rebased and merged as fbec267 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:
mainbranch and squash your commits