Skip to content

refactor SimpleLoggerAdvisor #2597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dev-jonghoonpark
Copy link
Contributor

Modifications:

1. added constructor

Although the LoggerAdvisor documentation mentions the following constructor, the SimpleLoggerAdvisor class did not have it in the code.
I added the following constructor to SimpleLoggerAdvisor:

SimpleLoggerAdvisor(
    Function<AdvisedRequest, String> requestToString,
    Function<ChatResponse, String> responseToString
)

2. changed to use Method References for DEFAULT_REQUEST_TO_STRING and DEFAULT_RESPONSE_TO_STRING

3. changed order variable to final

Signed-off-by: jonghoon park <[email protected]>
@dev-jonghoonpark dev-jonghoonpark force-pushed the refactor-simple-logger-advisor branch from 03a14a9 to e9cc4b9 Compare April 9, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant