Simplify RemoveJsonAttributesResponseBodyGatewayFilterFactory #3776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raccoonback
commented
Apr 21, 2025
| } | ||
| catch (JsonProcessingException e) { | ||
| throw new RuntimeException(e); | ||
| return Mono.error(new IllegalStateException("Failed to process JSON of response body.", e)); |
There was a problem hiding this comment.
-
The caller wraps the error with
Mono.error()to preserve the reactive pipeline and allow proper error handling. -
The exception type has been explicitly changed to
IllegalStateException.
Comment on lines
+96
to
+101
| private void removeJsonAttributes(JsonNode jsonNode, List<String> fieldNames, boolean deleteRecursively) { | ||
| if (jsonNode instanceof ObjectNode objectNode) { | ||
| objectNode.remove(fieldNames); | ||
| } | ||
| if (jsonBodyContent instanceof ObjectNode) { | ||
| ((ObjectNode) jsonBodyContent).remove(fieldsToRemove); | ||
| if (deleteRecursively) { | ||
| jsonNode.forEach(childNode -> removeJsonAttributes(childNode, fieldNames, true)); |
There was a problem hiding this comment.
Modified the logic to recursively remove JSON nodes without type distinction, allowing recursive calls regardless of node type.
|
Can you submit this against the 4.1.x branch? |
…actory Signed-off-by: raccoonback <[email protected]>
raccoonback
force-pushed
the
refactor-json-field-removal-filter
branch
from
c991ecd to
2458503
Compare
|
@ryanjbaxter I've changed the target to the 4.1.x branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request refactors the filter responsible for removing fields from JSON-formatted response bodies.
Simplified the filtering logic for better readability, and improved internal method structure and naming.
Changes
Mono.error().This allows the calling side to handle errors explicitly within the Reactive pipeline.
The change does not affect backward compatibility.
IllegalStateException.I think using a more specific exception type would improve clarity.
Let me know if further adjustments are needed.