Skip to content

Commit

Permalink
build: remove broken testing and deps
Browse files Browse the repository at this point in the history
Was flaky and hasn't been run regularly, so probably also incorrect by now.
  • Loading branch information
arildm committed Jan 27, 2025
1 parent 876f2c1 commit 34c01e9
Show file tree
Hide file tree
Showing 12 changed files with 21 additions and 1,713 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
- Removed `$rootScope._settings`, use `import settings from "@/settings"` instead
- Removed `$rootScope.openErrorModal()`, use `$uibModal` directly instead
- Result tab progress bars grow smoothly and are shown even when only one corpus is selected
- Removed old test code

## [9.8.1] - 2025-01-23

Expand Down
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ Install `yarn`: `https://yarnpkg.com`
- install all dependencies: `yarn`
- run development server: `yarn start`
- build a dist-version: `yarn build`
- run dist-version: `yarn start:dist`
- run tests: `yarn test` or `yarn test:karma` or `yarn test:e2e` (tests currently depend on Språkbankens setup).

Declare dependencies using `yarn add pkg`or `yarn add --dev pkg` for dev dependencies.

Expand Down
8 changes: 0 additions & 8 deletions app/index.ts
Original file line number Diff line number Diff line change
@@ -1,26 +1,18 @@
/** @format */
import $ from "jquery"
import currentMode from "@/mode"
import { locationSearchGet } from "@/util"
import { HashParams } from "@/urlparams"
import "@fontsource/source-sans-pro/400.css"
import "@fontsource/source-sans-pro/600.css"

declare global {
interface Window {
jQuery: JQueryStatic
$: JQueryStatic
/**
* TODO Remove, currently used in tests
* @deprecated
*/
locationSearch: <K extends keyof HashParams>(key: K) => HashParams[K]
}
}

window.jQuery = $
window.$ = $
window.locationSearch = locationSearchGet

require("slickgrid/slick.grid.css")
require("./styles/ui_mods.css")
Expand Down
2 changes: 1 addition & 1 deletion doc/frontend_devel.md
Original file line number Diff line number Diff line change
Expand Up @@ -877,4 +877,4 @@ Update this document if needed.

### Testing

The state of the frontend testing is quite bad. It is good to add e2e tests in `test/e2e/spec`, but not a demand. The tests are dependent on Språkbanken's frontend setup, Korp backend and Karp backend (auto completion feature).
Previous test code has been flaky and underprioritized, and is now removed. To examine or restore it, filter the git log for changes to the `test/` folder.
11 changes: 0 additions & 11 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,28 +33,23 @@
"xstate": "4.35.4"
},
"devDependencies": {
"@types/jasmine": "^5.1.4",
"@types/jquery": "^3.5.29",
"@types/js-yaml": "^4.0.9",
"@types/lodash": "^4.14.118",
"autoprefixer": "^10.2.4",
"chromedriver": "^122.0.4",
"compression-webpack-plugin": "^10.0.0",
"copy-webpack-plugin": "^11.0.0",
"css-loader": "^6.0.0",
"dotenv": "^16.4.5",
"html-loader": "^4.0.0",
"html-webpack-plugin": "^5.6.0",
"jasmine-core": "^4.0.0",
"postcss-loader": "^7.0.0",
"prettier": "^2.0.5",
"protractor": "^5.4.2",
"sass": "~1.49.9",
"sass-loader": "^13.0.0",
"style-loader": "^3.0.0",
"ts-loader": "^9.0.0",
"typescript": "^4.0.0",
"wait-on": "^7.0.0",
"webpack": "^5.0.0",
"webpack-bundle-analyzer": "^4.0.0",
"webpack-cli": "^5.0.0",
Expand All @@ -66,15 +61,9 @@
"node": ">=18"
},
"scripts": {
"test": "yarn run test:e2e",
"posttest": "kill $(lsof -t -i:9112)",
"pretest:e2e": "yarn run testserver && wait-on --delay 500 --interval 500 http://localhost:9112",
"test:e2e": "yarn protractor || true",
"protractor": "KORP_HOST=localhost node_modules/protractor/bin/protractor --browser chrome test/e2e/conf_e2e.js",
"start": "webpack-dev-server --config webpack.dev.js",
"start:labb": "ENVIRONMENT=staging webpack-dev-server --config webpack.dev.js",
"dev": "webpack-dev-server --config webpack.dev.js",
"testserver": "KORP_HOST=localhost KORP_HTTPS= webpack-dev-server --config webpack.dev.js --port 9112 &",
"build": "ENVIRONMENT=production webpack --config webpack.prod.js",
"build:labb": "ENVIRONMENT=staging webpack --config webpack.prod.js",
"format": "prettier . --write --ignore-path .gitignore"
Expand Down
29 changes: 0 additions & 29 deletions test/e2e/conf_e2e.js

This file was deleted.

37 changes: 0 additions & 37 deletions test/e2e/spec/autocomplete.js

This file was deleted.

60 changes: 0 additions & 60 deletions test/e2e/spec/compare.js

This file was deleted.

33 changes: 0 additions & 33 deletions test/e2e/spec/freeorder.js

This file was deleted.

56 changes: 0 additions & 56 deletions test/e2e/spec/misc.js

This file was deleted.

Loading

0 comments on commit 34c01e9

Please sign in to comment.