Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had a play with solving this one: #51
CL:
Array[Int]
. Is efficient because it iterates over the input Array once (O(n)
) using a fold.Int
data types with Feature Builder specifically for Segment IndicesTesting-wise, I've verified the results on a few arrays manually by running the Example as well as adding a property test which checks the result on 100 randomly generated (and valid) arrays. It does not 100% follow the pattern of other property tests in the repo which check for feature column names etc.
Welcome any suggestions, especially from someone with knowledge on the repo, as I think the core algorithm is solid but unsure what more of the surrounding code needs work.