Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Segment Indices transformer #536

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

aaronquantexa
Copy link

@aaronquantexa aaronquantexa commented Jun 20, 2021

Had a play with solving this one: #51

CL:

Testing-wise, I've verified the results on a few arrays manually by running the Example as well as adding a property test which checks the result on 100 randomly generated (and valid) arrays. It does not 100% follow the pattern of other property tests in the repo which check for feature column names etc.

Welcome any suggestions, especially from someone with knowledge on the repo, as I think the core algorithm is solid but unsure what more of the surrounding code needs work.

@aaronquantexa
Copy link
Author

In the file: SegmentIndicesSpec.scala, I had a functional-looking version of implementing the Arbitrary randomIncreasingArray which used a fold but it was less clear than the mutable alternative, which suits the dynamic style of the logic, so went with that implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant