fix: Add default values on decoding for ResolveResponse #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziodemaria
requested review from
mfranberg,
nicklasl,
nickybondarenko and
vahidlazio
as code owners
fabriziodemaria
force-pushed
the
default-values-json
branch
from
d458e09 to
56c7d82
Compare
fabriziodemaria
changed the title
fabriziodemaria
force-pushed
the
default-values-json
branch
3 times, most recently
from
975f02c to
ffca181
Compare
nicklasl
reviewed
Feb 10, 2025
| case flag, value, variant, flagSchema, reason | ||
| } | ||
|
|
||
| init( |
There was a problem hiding this comment.
Do I understand correctly that this function will throw if flag and reason is not set but will return correctly if other fields being missing?
How come we make this change now? What prompted it?
There was a problem hiding this comment.
Yes, this change came from trying out a different version of our backend resolver that would return no entries in the JSON rather than empty ones, in some cases
nicklasl
approved these changes
Feb 10, 2025
fabriziodemaria
force-pushed
the
default-values-json
branch
2 times, most recently
from
f6bff86 to
65f1a16
Compare
Signed-off-by: Fabrizio Demaria <[email protected]>
fabriziodemaria
force-pushed
the
default-values-json
branch
from
65f1a16 to
f374273
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing values from JSON should map to default values (i.e. empty) for
valuevariantandflagSchema